Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Fantomas out-of-process #252

Merged
merged 17 commits into from
May 13, 2021
Merged

Move Fantomas out-of-process #252

merged 17 commits into from
May 13, 2021

Conversation

DedSec256
Copy link
Collaborator

No description provided.

@nojaf
Copy link
Contributor

nojaf commented Apr 5, 2021

Hey Alex, this looks interesting! Could you elaborate a bit more on what the main idea is here?
I assume the end goal is to be more flexible in updating Fantomas.
Would the user be able to bring their own version of Fantomas?

I'm asking because I was messing around with a similar idea.
I had in mind to be able to start a Fantomas process as a language server and keep it running.
Editor tooling could then connect to this and format on demand.
The idea is that the version pinned in the tool manifest of the user could be used by the editor.

Perhaps some synergy is possible between this PR and my experiment.

@DedSec256
Copy link
Collaborator Author

Hi @nojaf!
This pull request contains the preparatory part required to run Fantomas and its dependencies in a separate process (currently the bundled by default version).

Yes, in the future it is planned to add support for pinned custom Fantomas version in a separate PR (:
Thanks for the link to your experiment, I'll take a look at this.

@DedSec256 DedSec256 force-pushed the net212-ber.a-fantomas branch 2 times, most recently from 967422d to 92d10c6 Compare April 22, 2021 10:28
auduchinok
auduchinok reviewed Apr 22, 2021
View reviewed changes
ReSharper.FSharp/src/FSharp.ExternalFormatter.Host/src/CodeFormatterProvider.cs Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.ExternalFormatter.Host/FSharp.ExternalFormatter.Host.csproj Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.ExternalFormatter.Host/src/ExternalFormatterAssemblyResolver.cs Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.ExternalFormatter.Host/src/ExternalFormatterEndPoint.cs Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.ExternalFormatter.Protocol/src/ExternalFormatterProcess.cs Outdated Show resolved Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Features/src/Formatter/FSharpReformatCode.fs Outdated Show resolved Hide resolved
rider-fsharp/protocol/src/kotlin/model/RdFSharpExternalFormatterModel.kt Outdated Show resolved Hide resolved
rider-fsharp/protocol/src/kotlin/model/RdFSharpExternalFormatterModel.kt Outdated Show resolved Hide resolved
rider-fsharp/protocol/src/kotlin/model/RdFSharpExternalFormatterModel.kt Outdated Show resolved Hide resolved
@auduchinok
Copy link
Collaborator

@DedSec256 Could you also please add tests or either/both backend and frontend?

The start looks good!

@DedSec256 DedSec256 force-pushed the net212-ber.a-fantomas branch 2 times, most recently from 671a500 to 1c63167 Compare May 4, 2021 10:29
@DedSec256 DedSec256 force-pushed the net212-ber.a-fantomas branch from d14e5cb to 9b4ef1e Compare May 11, 2021 11:11
@DedSec256 DedSec256 force-pushed the net212-ber.a-fantomas branch from 9b4ef1e to b1eb556 Compare May 13, 2021 09:02
auduchinok
auduchinok requested changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DedSec256 Could you finish the remaining bits, please?

@auduchinok auduchinok merged commit 95d1c13 into net212 May 13, 2021
@DedSec256 DedSec256 changed the title Move Fantomas out-of-process [<WIP>] Move Fantomas out-of-process May 13, 2021
@auduchinok auduchinok mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DedSec256 @nojaf @auduchinok